[lkml]   [2007]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [discuss] [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
>>> Andrew Morton <> 09.01.07 23:04 >>>
>On Tue, 9 Jan 2007 12:01:21 +0100
>Andi Kleen <> wrote:
>> On Tuesday 09 January 2007 03:55, Adrian Bunk wrote:
>> > RESTORE_CONTEXT lost a newline in
>> > commit 658fdbef66e5e9be79b457edc2cbbb3add840aa9:
>> >
>> I don't think we should add such changes for external patchkits.
>> In general kgdb shouldn't add any patches at all. If the existing
>> hooks are not enough they should submit their changes needed so
>> that it can just work.
>But the patch is a bugfix. Without it, you cannot do
> .globl ... \

Their use was broken in the first place - they shouldn't have made
assumptions about the contents of the macro, by writing this like

".globl ..." \

if they really need to make use of the macro. This is similar to
requirements of other (assembly) macros that normally also
don't have a line terminator and hence require the users to
add appropriate line termination after the macro name (and
eventual arguments).

I would even go as far as asking for removing the \n\t on SAVE_CONTEXT
and the left \t on RESTORE_CONTEXT.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-01-10 10:37    [W:0.060 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site