lkml.org 
[lkml]   [2006]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] watchdog: add support for w83697hg chip
    > Pádraig Brady wrote:
    > > Is W83697HG a good name?
    > >
    >
    >
    > could you add a suffix, say _watchdog ?
    >
    > the name youve got is confusingly close to the convention used in
    > drivers/hwmon
    >
    > ls hwmon/w*.c
    > hwmon/w83627ehf.c hwmon/w83627hf.c hwmon/w83781d.c hwmon/w83791d.c
    > hwmon/w83792d.c hwmon/w83l785ts.c

    I second Jim's suggestion. Given the name of the other Winbond watchdog
    drivers:

    char/watchdog/w83627hf_wdt.c
    char/watchdog/w83977f_wdt.c
    char/watchdog/w83877f_wdt.c

    I'd suggest w83697hf_wdt.c. The W83697HG if the lead-free version of
    the older W83697HF and they are otherwise the same chip. BTW I see that
    there's already a driver for the W83627HF watchdog. Given the
    similarities between the W83627HF and the W83697HF, it might make sense
    to add support for the latter directly in the w83627hf_wdt driver,
    rather than writing a brand new one.

    --
    Jean Delvare
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-08 14:25    [W:0.036 / U:0.764 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site