lkml.org 
[lkml]   [2006]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
Date
Jan Engelhardt <jengelh@linux01.gwdg.de> writes:

>>> +static struct pid_entry proc_base_stuff[] = {
>>> + NOD(PROC_TGID_INO, "self", S_IFLNK|S_IRWXUGO,
>>> + &proc_self_inode_operations, NULL, {}),
>>> + {}
>>> +};
>>
>>We could save a bunch of bytes here.
>>
>>> + /* Lookup the directory entry */
>>> + for (p = proc_base_stuff; p->name; p++) {
>>
>>By using ARRAY_SIZE here.
>>
>>> + for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>>
>>like that does.
>
> Also works without the () around ARRAY_SIZE(..)-1

Sure. But I don't really trust C precedence (because it is wrong)
and having to remember where it is wrong sucks. Plus in this
case I really am making it clear that ARRAY_SIZE(..)-1 is the concept
I want. If there would any more to the expression that would
be important.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-08 13:07    [W:0.069 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site