lkml.org 
[lkml]   [2006]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature while sanity-checking an ATAPI device
Jeff Garzik wrote:
> Andrew Morton wrote:
>> You mean 2.6.18, yes?
>
> Actually, it looks like it should indeed be 2.6.19 (libata #upstream),
> not 2.6.18 (libata #upstream-fixes). Alan's "add compactflash support"
> patch isn't in 2.6.18-rc.
>
> So, this should -not- be sent for 2.6.18.

Hello,

Yes, I meant .18. Jeff, this should be fixed before 2.6.18 is released.
It's not the question of whether CFA support is implemented or not.
We're sanity-checking in 2.6.18-rcX anyway and it's the sanity checking
which is causing problem. What seems to have happened is...

1. CFA support is implemented
2. CFA check was added (backported) to upstream-fixes, but it was incorrect.

So, we need to do one of two things.

* apply this patch to 2.6.18-rcX
* remove ata_id_is_cfa() check altogether

--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-08 09:59    [W:0.085 / U:4.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site