lkml.org 
[lkml]   [2006]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

>> +static struct pid_entry proc_base_stuff[] = {
>> + NOD(PROC_TGID_INO, "self", S_IFLNK|S_IRWXUGO,
>> + &proc_self_inode_operations, NULL, {}),
>> + {}
>> +};
>
>We could save a bunch of bytes here.
>
>> + /* Lookup the directory entry */
>> + for (p = proc_base_stuff; p->name; p++) {
>
>By using ARRAY_SIZE here.
>
>> + for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>
>like that does.

Also works without the () around ARRAY_SIZE(..)-1



Jan Engelhardt
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-08 09:11    [W:0.077 / U:9.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site