Messages in this thread | | | Date | Fri, 8 Sep 2006 15:01:29 -0700 | From | Greg KH <> | Subject | Re: [PATCH] pktcdvd: added sysfs interface + bio write queue handling fix |
| |
On Fri, Sep 08, 2006 at 05:40:11PM -0400, Phillip Susi wrote: > Greg KH wrote: > >On Fri, Sep 08, 2006 at 07:55:08PM +0200, Thomas Maier wrote: > >>+/sys/block/pktcdvd/<pktdevname>/packet/ > >>+ statistic (r) Show device statistic. One line with > >>+ 5 values in following order: > >>+ packets-started > >>+ packets-end > >>+ written in kB > >>+ read gather in kB > >>+ read in kB > > > >Please no. One value per file is the sysfs rule. > > > > Except in cases like this where you want to read the status of the > device at a given point in time, and you can't do that unless you grab > all the values at once.
Then don't use sysfs for that. And is something like this as critical to get that kind of information all in one atomic chunk? It seems merely to be informational.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |