Messages in this thread |  | | From | Andreas Schwab <> | | Subject | Re: [PATCH 07/16] GFS2: Directory handling | | Date | Tue, 05 Sep 2006 10:58:07 +0200 |
| |
Ingo Molnar <mingo@elte.hu> writes:
> * Steven Whitehouse <swhiteho@redhat.com> wrote: > >> > >+static inline int __gfs2_dirent_find(const struct gfs2_dirent *dent, >> > >+ const struct qstr *name, int ret) >> > >+{ >> > >+ if (dent->de_inum.no_addr != 0 && >> > >+ be32_to_cpu(dent->de_hash) == name->hash && >> > >+ be16_to_cpu(dent->de_name_len) == name->len && >> > >+ memcmp((char *)(dent+1), name->name, name->len) == 0) >> > >> > Nocast. >> > >> ok > > actually, sizeof(*dent) != 1, so how can a non-casted memcmp be correct > here?
How can the cast change anything?
Andreas.
-- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |