lkml.org 
[lkml]   [2006]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[2.6 patch] drivers/scsi/wd33c93.c: cleanups
    On Mon, Aug 21, 2006 at 12:31:42PM -0700, David Miller wrote:
    > From: Adrian Bunk <bunk@stusta.de>
    > Date: Mon, 21 Aug 2006 21:22:15 +0200
    >
    > > On Mon, Aug 21, 2006 at 11:53:44AM +0100, Christoph Hellwig wrote:
    > > > On Mon, Aug 21, 2006 at 12:43:57PM +0200, Adrian Bunk wrote:
    > > > > This patch contains the following cleanups:
    > > > > - #include <linux/irq.h> for getting the prototypes of
    > > > > {dis,en}able_irq()
    > > >
    > > > nothing outside of arch code must ever include <linux/irq.h>
    > >
    > > Why?
    > > It sounds rather strange that non-arch code should use asm headers.
    >
    > It's an unfortunate side effect of how the generic IRQ layer was done.
    >
    > The linux/irq.h head should only be used on platforms that make use of
    > the generic IRQ layer.
    >
    > asm/irq.h is what should be included by drivers and the like that want
    > the IRQ interfaces.
    >
    > I'm not saying this is a good situation, it's just the way it is.

    What a mess...

    Updated patch below.

    cu
    Adrian


    <-- snip -->


    This patch contains the following cleanups:
    - #include <asm/irq.h> for getting the prototypes of
    {dis,en}able_irq()
    - make the needlessly global wd33c93_setup() static

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.18-rc5-mm1/drivers/scsi/wd33c93.c.old 2006-09-04 01:45:57.000000000 +0200
    +++ linux-2.6.18-rc5-mm1/drivers/scsi/wd33c93.c 2006-09-04 01:46:26.000000000 +0200
    @@ -85,6 +85,8 @@
    #include <scsi/scsi_device.h>
    #include <scsi/scsi_host.h>

    +#include <asm/irq.h>
    +
    #include "wd33c93.h"


    @@ -1710,7 +1712,7 @@
    static char setup_used[MAX_SETUP_ARGS];
    static int done_setup = 0;

    -int
    +static int
    wd33c93_setup(char *str)
    {
    int i;

    --
    VGER BF report: H 0.177864
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-04 13:45    [W:0.025 / U:117.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site