Messages in this thread | | | Date | Mon, 4 Sep 2006 18:48:19 +1000 | Subject | Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM | From | Herbert Xu <> |
| |
On Mon, Sep 04, 2006 at 12:44:14PM +0400, Alexey Kuznetsov wrote: > > Seems, it serializes mod_timer and timer handler to keep timer > in predictable state. Maybe, this is not necessary. A priori, it is required. > > Note that in dev_watchdog_down() queue_lock is released before > taking xmit_lock. Probably, this is the thing which was supposed > to be done in dev_watchdog_up() too.
Right, in that case this should definitely be unncessary because both dev_watchdog_up and dev_watchdog_up are called under RTNL.
The function __dev_watchdog_up could possibly be dodgy though but that's a different story.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-- VGER BF report: H 3.52484e-12 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |