lkml.org 
[lkml]   [2006]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [RFC][PATCH 1/2] ACPI: Idle Processor PM Improvements
From
Date
Hi Pavel,

On Mon, 2006-09-04 at 12:59 +0000, Pavel Machek wrote:
> Hi!
>
> > This patch improves the ACPI c-state selection algorithm. It also
> > includes a major cleanup and simplification of the processor idle code.
>
> Nice!
>
> > @@ -1009,7 +883,7 @@
> >
> > seq_printf(seq, "active state: C%zd\n"
> > "max_cstate: C%d\n"
> > - "bus master activity: %08x\n",
> > + "bus master activity: %d\n",
> > pr->power.state ? pr->power.state - pr->power.states : 0,
> > max_cstate, (unsigned)pr->power.bm_activity);
> >
>
> This changes kernel - user interface. You should change the field
> description, or keep it in hex...

Good catch! Essentially the field now counts the number of times bus
master activity was detected, rather than bitshifting. I'll change its
name in the next iteration.

>
> BTW will you be on september's labs conference?

It's not currently in my plans, but I'd love to attend one at some
point.

>
> Pavel

Thanks for the comments.

Regards,
Adam

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-05 04:21    [W:0.048 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site