Messages in this thread | | | Date | Mon, 04 Sep 2006 16:23:11 +0400 | From | Kirill Korotaev <> | Subject | Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core) |
| |
Dave Hansen wrote: > On Tue, 2006-08-29 at 18:58 +0400, Kirill Korotaev wrote: > >>@@ -274,8 +274,14 @@ struct page { >> unsigned int gfp_mask; >> unsigned long trace[8]; >> #endif >>+#ifdef CONFIG_BEANCOUNTERS >>+ union { >>+ struct beancounter *page_bc; >>+ } bc; >>+#endif >> }; > > > I know you're probably saving this union for when you put some userspace > stuff in here or something. But, for now, it would probably be best > just to leave it as a plain struct, or even an anonymous union. > > You probably had to use gcc 2 when this was written and couldn't use > anonymous unions, right? are you suggesting the code like this: >>+#ifdef CONFIG_BEANCOUNTERS >>+ union { >>+ struct beancounter *page_bc; >>+ }; >>+#endif >> };
#define page_bc(page) ((page)->page_bc) ?
> -- Dave > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > ckrm-tech mailing list > https://lists.sourceforge.net/lists/listinfo/ckrm-tech >
-- VGER BF report: H 5.55112e-17 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |