Messages in this thread | | | Date | Fri, 29 Sep 2006 13:35:56 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.3.2 (core) |
| |
On 9/29/06, Randy Dunlap <rdunlap@xenotime.net> wrote: > On Fri, 29 Sep 2006 16:24:15 +0800 raise.sail wrote: > > > Changelogs: > > > > 1. A bugfix for clear usage process. > > > > This driver requires: > > 1. [PATCH] usb: HID Simple Driver Interface 0.3.1 (Kconfig and Makefile), this patch can be used without any change. > > > > PS: Who is the maintainer of the input subsystem today? Should I forward this mail to him/her? >
I re-read these patches again and the main problem with the current implementation is that it alters input devices's properties after device has been registered and presented to userspace. That means that hotplug users that presently can inspect device's capabilities and decide if they are "interested" in device will not be able to do so anymore. For example I think X event interface drivers examine input devices and decide if it should be handled by as keyboard or pointing device so it is possible for them to not notice that touchpad capabilities were added to a keyboard later. For now the only thing that is allowed to change after device has been registered is keymap.
Then there is issue with automatic loading of these sub-drivers. How do they get loaded? Or we force everything to be built-in making HID module very fat (like psmouse got pretty fat, but with HID prtential for it to get very fat is much bigger).
The better way would be to split hid-input into a library module that parses hid usages and reports and is shared between device-specific modules that are "real" drivers (usb-drivers, not hid-sub-drivers).
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |