lkml.org 
[lkml]   [2006]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Date
From
SubjectRe: [PATCH] Put the BUG __FILE__ and __LINE__ info out of line
On Thu, Sep 28, 2006 at 03:30:12AM -0700, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> >But no out of line section. So overall it's smaller, although the cache
> >footprint
> >is 2 bytes larger. But then is 2 bytes larger really an issue? We don't
> >have
> >_that_ many BUGs anyways.
> >
>
> I think the out of line section is a feature; no point in crufting up
> the icache with BUG gunk, especially since a number of them are on
> fairly hot paths.

It's 10 bytes per BUG.

>
> >I'll port the x86-64 way over to i386
>
> It's neat, and it would solve my immediate problem, but I think my way
> is actually better.

Your way will be even bigger because we would need to add
dwarf2 annotation to the out of line code.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-28 12:43    [W:0.082 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site