lkml.org 
[lkml]   [2006]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 002 of 8] knfsd: lockd: fix refount on nsm.

    If nlm_lookup_host finds what it is looking for
    it exits with an extra reference on the matching
    'nsm' structure.
    So don't actually count the reference until we are
    (fairly) sure it is going to be used.

    Signed-off-by: Neil Brown <neilb@suse.de>

    ### Diffstat output
    ./fs/lockd/host.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff .prev/fs/lockd/host.c ./fs/lockd/host.c
    --- .prev/fs/lockd/host.c 2006-09-29 11:44:21.000000000 +1000
    +++ ./fs/lockd/host.c 2006-09-29 11:55:15.000000000 +1000
    @@ -103,8 +103,8 @@ nlm_lookup_host(int server, const struct
    continue;

    /* See if we have an NSM handle for this client */
    - if (!nsm && (nsm = host->h_nsmhandle) != 0)
    - atomic_inc(&nsm->sm_count);
    + if (!nsm)
    + nsm = host->h_nsmhandle;

    if (host->h_proto != proto)
    continue;
    @@ -120,6 +120,8 @@ nlm_lookup_host(int server, const struct
    nlm_get_host(host);
    goto out;
    }
    + if (nsm)
    + atomic_inc(&nsm->sm_count);

    host = NULL;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-09-29 05:13    [W:0.029 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site