lkml.org 
[lkml]   [2006]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix compiler warning in drivers/media/video/video-buf.c
On Thu, 28 Sep 2006 10:31:58 -0700
Martin Bligh <mbligh@google.com> wrote:

> Using a double cast to avoid compiler warnings when
> building for PAE. Compiler doesn't like direct casting
> of a 32 bit ptr to 64 bit integer.
>
> ...
>
> diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.18/drivers/media/video/video-buf.c 2.6.18-videobuf/drivers/media/video/video-buf.c
> --- linux-2.6.18/drivers/media/video/video-buf.c 2006-06-17 18:49:35.000000000 -0700
> +++ 2.6.18-videobuf/drivers/media/video/video-buf.c 2006-09-28 10:28:54.000000000 -0700
> @@ -365,7 +365,12 @@ videobuf_iolock(struct videobuf_queue* q
> if (NULL == fbuf)
> return -EINVAL;
> /* FIXME: need sanity checks for vb->boff */
> - bus = (dma_addr_t)fbuf->base + vb->boff;
> + /*
> + * Using a double cast to avoid compiler warnings when
> + * building for PAE. Compiler doesn't like direct casting
> + * of a 32 bit ptr to 64 bit integer.
> + */
> + bus = (dma_addr_t)(size_t)fbuf->base + vb->boff;
> pages = PAGE_ALIGN(vb->size) >> PAGE_SHIFT;
> err = videobuf_dma_init_overlay(&vb->dma,PCI_DMA_FROMDEVICE,
> bus, pages);
>

We normally cast pointers to unsigned long prior to assigning them to
64-bit values. I'll make that change.

That being said, this driver is wrong to be storing dma addresses in a
void*. And indeed there is a FIXME regarding this at
include/linux/videodev2.h:476, so I guess hiding this warning won't obscure
any fault which wasn't already known about..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-28 19:55    [W:0.039 / U:1.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site