Messages in this thread Patch in this message | | | Subject | [PATCH] JBD: Make journal_do_submit_data static | From | Dave Kleikamp <> | Date | Thu, 28 Sep 2006 10:03:56 -0500 |
| |
On Wed, 2006-09-27 at 17:01 -0500, Eric Sandeen wrote: > Andrew Morton wrote: > > On Wed, 13 Sep 2006 15:25:19 -0500 > > Dave Kleikamp <shaggy@austin.ibm.com> wrote: > > > >>> +void journal_do_submit_data(struct buffer_head **wbuf, int bufs) > >> Is there any reason this couldn't be static? > > > > Nope. > > With this change, journal_brelse_array can also be made static in > recovery.c, and removed from jbd.h, I think.
Looks like it. Here's a patch to do that:
JBD: Make journal_brelse_array static
It's always good to make symbols static when we can, and this also eliminates the need to rename the function in jbd2
suggested by Eric Sandeen
Signed-off-by: Dave Kleikamp <shaggy@austin.ibm.com> Cc: Eric Sandeen <sandeen@sandeen.net>
diff --git a/fs/jbd/recovery.c b/fs/jbd/recovery.c index 445eed6..11563fe 100644 --- a/fs/jbd/recovery.c +++ b/fs/jbd/recovery.c @@ -46,7 +46,7 @@ static int scan_revoke_records(journal_t #ifdef __KERNEL__ /* Release readahead buffers after use */ -void journal_brelse_array(struct buffer_head *b[], int n) +static void journal_brelse_array(struct buffer_head *b[], int n) { while (--n >= 0) brelse (b[n]); diff --git a/include/linux/jbd.h b/include/linux/jbd.h index a6d9daa..fe89444 100644 --- a/include/linux/jbd.h +++ b/include/linux/jbd.h @@ -977,7 +977,6 @@ extern void journal_write_revoke_reco extern int journal_set_revoke(journal_t *, unsigned long, tid_t); extern int journal_test_revoke(journal_t *, unsigned long, tid_t); extern void journal_clear_revoke(journal_t *); -extern void journal_brelse_array(struct buffer_head *b[], int n); extern void journal_switch_revoke_table(journal_t *journal); /* -- David Kleikamp IBM Linux Technology Center
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |