Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] Blackfin: arch patch for 2.6.18 | Date | Thu, 28 Sep 2006 13:04:30 +0200 |
| |
On Thursday 28 September 2006 11:31, Bernd Schmidt wrote: > > > > That completely avoids all the problems you might hit with macro expansion, > > while still compiling to the same code. > > The operand is an input, not an output.
ok, my fault.
> We want to restore the proper > mask of enabled interrupts with the STI. That mask is in the global > irq_flags variable (which probably ought to have a different name that > doesn't invite clashes).
Shouldn't you just use a constant expression here? A global variable for it sounds rather strange, especially since the local_irq_disable() calls are sometimes nested, not to mention the problems you'd hit on SMP?
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |