Messages in this thread Patch in this message | | | Date | Wed, 27 Sep 2006 21:05:18 -0400 | From | Jeff Garzik <> | Subject | [PATCH] device_for_each_child(): kill pointless warning noise |
| |
As the last patch demonstrated, it is quite valid for a caller to ignore the return value of device_for_each_child(), given that the return value is wholly dependent on the actor -- which in practice often has a hardcoded return value.
Please apply, to reduce a portion of the warning explosion seen in current linux-2.6.git.
Signed-off-by: Jeff Garzik <jeff@garzik.org>
diff --git a/include/linux/device.h b/include/linux/device.h index 662e6a1..9d4f6a9 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -393,7 +393,7 @@ extern void device_unregister(struct dev extern void device_initialize(struct device * dev); extern int __must_check device_add(struct device * dev); extern void device_del(struct device * dev); -extern int __must_check device_for_each_child(struct device *, void *, +extern int device_for_each_child(struct device *, void *, int (*fn)(struct device *, void *)); extern int device_rename(struct device *dev, char *new_name); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |