Messages in this thread | | | Date | Wed, 27 Sep 2006 15:50:35 -0700 (PDT) | Subject | Re: + msi-refactor-and-move-the-msi-irq_chip-into-the-arch-code.patch added to -mm tree | From | David Miller <> |
| |
From: akpm@osdl.org Date: Wed, 27 Sep 2006 15:15:37 -0700
> Subject: msi: refactor and move the msi irq_chip into the arch code > From: "Eric W. Biederman" <ebiederm@xmission.com> > > It turns out msi_ops was simply not enough to abstract the architecture > specific details of msi. So I have moved the resposibility of constructing > the struct irq_chip to the architectures, and have two architecture specific > functions arch_setup_msi_irq, and arch_teardown_msi_irq. > > For simple architectures those functions can do all of the work. For > architectures with platform dependencies they can call into the appropriate > platform code. > > With this msi.c is finally free of assuming you have an apic, and this > actually takes less code. > > The helpers for the architecture specific code are declared in the linux/msi.h > to keep them separate from the msi functions used by drivers in linux/pci.h > > Signed-off-by: Eric W. Biederman <ebiederm@xmission.com> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Tony Luck <tony.luck@intel.com> > Cc: Andi Kleen <ak@suse.de> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Greg KH <greg@kroah.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Signed-off-by: Andrew Morton <akpm@osdl.org>
Eric, thanks so much for doing this work.
Once this goes in I'll try to add support for MSI on sparc64 Niagara boxes. I suppose the PowerPC folks can make use of this as well.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |