Messages in this thread | | | Subject | Re: [PATCH] libata: rework legacy handling to remove much of the cruft | From | Alan Cox <> | Date | Mon, 25 Sep 2006 12:18:02 +0100 |
| |
Ar Llu, 2006-09-25 am 11:14 +0100, ysgrifennodd David Woodhouse: > We should register the non-discoverable devices as platform devices (or > of_devices, or something), and not just hardcode stuff like this in > asm/foo.h headers
That would be too late. Those "constants"[1] are part of the actual PCI bus setup. I have some patches to push most of them into drivers/pci/quirks.c. We cannot use platform devices for this in most cases because we already have a device for it - the PCI one.
In the non PCI case we can use platform devices and we do, but the platform device itself has to know what I/O ports are being used so you end up back with the "constants".
The old IDE layer works this way too except that it doesn't use platform devices at all.
Alan [1] as in "constants aren't, variables won't"
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |