lkml.org 
[lkml]   [2006]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH]: PCI Error Recovery: Symbios SCSI device driver
From
On Fri, Sep 22, 2006 at 04:39:29PM -0700, Randy.Dunlap wrote:
> On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:
>
> > On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:
> > >
> > > Space after function name? You put in other places too, it's not
> > > consistent with the rest of the patch.
> >
> > Oops. I was also coding on a different project recently, with a
> > different style. I'll send a revised patch in a moment.
>
> Please change if()'s to use
>
> if (var == constant)
> instead of
> if (constant == var)

Yuck! Horrid coding style! No rational excuse for coding like that.
Advice taken under protest; new patch shortly.

--linas

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-23 01:53    [from the cache]
©2003-2011 Jasper Spaans