lkml.org 
[lkml]   [2006]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18
On 9/21/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Iau, 2006-09-21 am 11:33 +0800, ysgrifennodd Luke Yang:
> > Hi,
> >
> > This is the serial driver for Blackfin. It is designed for the serial
> > core framework.
>
> > +#define DMA_RX_XCOUNT TTY_FLIPBUF_SIZE
>
> TTY_FLIPBUF_SIZE is going away. Just pick a value good for your hardware
> and under PAGE_SIZE.

Thanks for your comments. I'll change it soon and submit a new patch.

>
> Other question - is your locking ok for low latency. In low latency mode
> tty_flip_buffer_push() may directly end up calling your write methods.
>
Yes, I noticed that and I think it's ok. The driver is tested everday
and works fine.

-Aubrey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-21 11:27    [W:2.830 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site