lkml.org 
[lkml]   [2006]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] FRV: Permit __do_IRQ() to be dispensed with
From
Date
On Thu, 2006-09-21 at 14:12 +0100, David Howells wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > It can't optimize __do_IRQ() out in any case if one uses
> > generic_handle_irq() because of the test in there which can't be
> > predicted at compile time.
>
> Do you realise that powerpc still uses __do_IRQ if CONFIG_IRQSTACKS=y? You
> should probably fix that.

At the moment, there is no hurry as this code is shared with arch/ppc
which hasn't been ported to genirq, so we need to handle both cases.
(Though I'm not sure we ever get CONFIG_IRQSTACKS with arch/ppc ... I
should probably check). The code uses desc->handle_irq and falls back to
__do_IRQ() if that is NULL.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-22 00:03    [W:0.079 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site