lkml.org 
[lkml]   [2006]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch02/05]: Containers(V2)- Generic Linux kernel changes
    From
    Date
    Rohit Seth <rohitseth@google.com> writes:
    > */
    > +#ifdef CONFIG_CONTAINERS
    > + struct container_struct *ctn; /* Pointer to container, may be NULL */
    > +#endif

    I still don't think it's a good idea to add a pointer to struct page for this.
    This means any kernel that enables the config would need to carry this significant
    overhead, no matter if containers are used to not.

    Better would be to store them in some other data structure that is only
    allocated on demand or figure out a way to store them in the sometimes
    not all used fields in struct page.

    BTW your patchkit seems to be also in wrong order in that when 02 is applied
    it won't compile.

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-20 13:31    [W:0.024 / U:59.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site