lkml.org 
[lkml]   [2006]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] pmc551 remove unnecessary braces
Josh Boyer wrote:
> On Tue, 2006-09-19 at 00:47 +0200, Jiri Slaby wrote:
>> diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
>> index 6d4d5a4..0ee22ca 100644
>> --- a/drivers/mtd/devices/pmc551.c
>> +++ b/drivers/mtd/devices/pmc551.c
>> @@ -137,11 +137,11 @@ #endif
>>
>> pmc551_point(mtd, instr->addr, instr->len, &retlen, &ptr);
>>
>> - if (soff_hi == eoff_hi || mtd->size == priv->asize) {
>> + if (soff_hi == eoff_hi || mtd->size == priv->asize)
>> /* The whole thing fits within one access, so just one shot
>> will do it. */
>> memset(ptr, 0xff, instr->len);
>> - } else {
>> + else {
>> /* We have to do multiple writes to get all the data
>> written. */
>> while (soff_hi != eoff_hi) {
>
> I actually find this change to make the code less readable. Yes, the
> braces aren't technically necessary, but the else requires them, and the
> comment block before the memset makes this multi-line.
>
> This whole patch is highly user preference, but I'd rather these braces
> stay.

Yes, I agree. This was one of my old patches stored on other PC, that I find
now. The patch definitely makes it ugly.

>> @@ -700,9 +695,8 @@ static int __init init_pmc551(void)
>>
>> if ((PCI_Device = pci_find_device(PCI_VENDOR_ID_V3_SEMI,
>> PCI_DEVICE_ID_V3_SEMI_V370PDC,
>> - PCI_Device)) == NULL) {
>> + PCI_Device)) == NULL)
>> break;
>> - }
>
> 1) If you're going for coding style, the assignment within the if
> condition needs to be moved outside of it.
>
> 2) If you're not going to fix 1, then leave the braces.

1) is fine, I will do it, thanks for comments.

--
http://www.fi.muni.cz/~xslaby/ Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8 22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-19 12:19    [W:0.038 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site