lkml.org 
[lkml]   [2006]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] pmc551 pci cleanup
Date
Am Dienstag, 19. September 2006 00:47 schrieb Jiri Slaby:
> pmc551 pci cleanup
>
> use pci_get_device -- refcounting, release it by pci_dev_put. Use
> pci_resource_start for getting start of regions.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
> commit 6fe18c54c93d38eec34ca0776da60fc355968f6b
> tree 5bf3cf8fe213de770c7c7a1279eafb3937f4c386
> parent 912ff3e53f760cb166988fcd46fc173f8e4c22e7
> author Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006 00:39:08
> +0200 committer Jiri Slaby <xslaby@anemoi.localdomain> Tue, 19 Sep 2006
> 00:39:08 +0200

You should change your .git/config and add a user section to get the mail
address correct I think.

> drivers/mtd/devices/pmc551.c | 21 +++++++++++++--------
> 1 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mtd/devices/pmc551.c b/drivers/mtd/devices/pmc551.c
> index 5f5de9c..d1ba4b9 100644
> --- a/drivers/mtd/devices/pmc551.c
> +++ b/drivers/mtd/devices/pmc551.c
> @@ -563,7 +563,7 @@ #ifdef CONFIG_MTD_PMC551_DEBUG
> size >> 10 : size >> 20,
> (size < 1024) ? 'B' : (size < 1048576) ? 'K' : 'M', size,
> ((dcmd & (0x1 << 3)) == 0) ? "non-" : "",
> - (unsigned long long)((dev->resource[0].start) &
> + (unsigned long long)(pci_resource_start(dev, 0) &
> PCI_BASE_ADDRESS_MEM_MASK));
>
> /*

The last part is unneeded in both versions, when resource[n].start is set the
PCI core already does the masking.

> @@ -755,14 +758,14 @@ static int __init init_pmc551(void)
> "size %dM\n", asize >> 20);
> priv->asize = asize;
> }
> - priv->start = ioremap(((PCI_Device->resource[0].start)
> - & PCI_BASE_ADDRESS_MEM_MASK),
> - priv->asize);
> + priv->start = ioremap(pci_resource_start(PCI_Device, 0) &
> + PCI_BASE_ADDRESS_MEM_MASK, priv->asize);

pci_iomap(PCI_Device, 0, priv->asize);

Eike
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-09-19 08:53    [W:0.039 / U:12.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site