Messages in this thread | | | Date | Tue, 19 Sep 2006 15:24:46 +0900 | From | Tejun Heo <> | Subject | Re: 2.6.18-rc7-git1: AHCI not seeing devices on ICH8 mobo (DG965RY) |
| |
Jeff Garzik wrote: > I don't really like this port_tbl approach. I think it complicates > things too much. > > Direct indexing should be fine. For the non-linear case, just make sure > the non-existent ports are always dummy ports. If the driver directly > references a port we know isn't there, that's just an AHCI bug to be > fixed...
I thought about that too, but it will end up with ata1-6 with dummy 3 and 4 while the BIOS shows continuous 4 ports. I wanted avoid this discrepancy as it could cause confusion to users.
The other option is adding pp->port_idx to record hw port index. It does make the code a bit simpler. What do you think about this?
Thanks.
-- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |