[lkml]   [2006]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] Linux Kernel Markers
    Martin Bligh wrote:

    > [...]
    > Depends what we're trying to fix. I was trying to fix two things:
    > 1. Flexibility - kprobes seem unable to access all local variables etc
    > easily, and go anywhere inside the function. Plus keeping low overhead
    > for doing things like keeping counters in a function (see previous
    > example I mentioned for counting pages in shrink_list).
    Using tools like systemtap on can consult DWARF information and put
    probes in the middle of the function and access local variables as well,
    that is not the real problem. The issue here is compiler doesn't seem to
    generate required DWARF information in some cases due to optimizations.
    The other related problem is when there exists debug information, the
    way to specify the breakpoint location is using line number which is not
    maintainable, having a marker solves this problem as well. Your proposal
    still doesn't solve the need for markers if i understood correctly.

    > 2. Overhead of the int3, which was allegedly 1000 cycles or so, though
    > faster after Ingo had played with it, it's still significant.

    The reason Kprobes use breakpoint instruction as pointed out by Prasanna
    is, it is atomic on most platforms. We are already working on an
    improved idea using jump instruction with which overhead is less than
    100 cycles on modern CPU's but it has some limitations and issues
    related to preemption and SMP.

    You can get a glimpse of some of the issues here
    For more details do a search for djprobe in the systemtap mailing list
    (sorry i am not able to find few threads to summarize all the issues).

    Here is the algorithm djprobes uses to

    [ins1][ins2][ ins3 ]
    [<- DCR ->]
    [<- JTPR ->]

    ins1: 1st Instruction
    ins2: 2nd Instruction
    ins3: 3rd Instruction
    IA: Insertion Address
    JTPR: Jump Target Prohibition Region
    DCR: Detoured Code Region

    The replacement procedure of djpopbes is the following (i have simplified for readability the actual steps djprobes uses)

    (1) copying instruction(s) in DCR
    (2) putting break point instruction at IA
    (3) make sure no cpu's have replacing instructions in the cache to avoid jump to the middle of jmp instruction
    (4) replacing original instruction(s) with jump instruction

    As you can see from the above your suggestion is very similar to the
    djprobes hence i believe all the issues related to djprobes will be
    valid for yours as well.

    > M.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2006-09-19 21:17    [W:0.023 / U:3.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site