lkml.org 
[lkml]   [2006]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108
    On Sat, Sep 16, 2006 at 09:37:45PM +0200, Ingo Molnar wrote:
    > --------------->
    > Subject: [patch] kprobes: speed INT3 trap handling up on i386
    > From: Ingo Molnar <mingo@elte.hu>
    >
    > speed up kprobes trap handling by special-casing kernel-space
    > INT3 traps (which do not occur otherwise) and doing a kprobes
    > handler check - instead of redirecting over the i386-die-notifier
    > chain.
    >
    Hi Ingo,

    Not that it would make any difference to the actual kprobe performance,
    but I think that not using the die-notifier chain makes the DIE_INT3
    handling in kprobe_exceptions_notify() useless.

    Regards,
    Frederik


    Signed-off-by: Frederik Deweerdt <frederik.deweerdt@gmail.com>

    diff --git a/arch/i386/kernel/kprobes.c b/arch/i386/kernel/kprobes.c
    index afe6505..90787ff 100644
    --- a/arch/i386/kernel/kprobes.c
    +++ b/arch/i386/kernel/kprobes.c
    @@ -652,10 +652,6 @@ int __kprobes kprobe_exceptions_notify(s
    return ret;

    switch (val) {
    - case DIE_INT3:
    - if (kprobe_handler(args->regs))
    - ret = NOTIFY_STOP;
    - break;
    case DIE_DEBUG:
    if (post_kprobe_handler(args->regs))
    ret = NOTIFY_STOP;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-09-17 10:17    [W:0.025 / U:0.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site