lkml.org 
[lkml]   [2006]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/16] GFS2: File and inode operations
> 
> >+struct file gfs2_internal_file_sentinal = {
> >+ .f_flags = O_NOATIME|O_RDONLY,
> >+};

Statically allocation a struct file is not allowed. Where do you use
gfs2_internal_read? It really shouldn't be needed.

> >+static int gfs2_readdir(struct file *file, void *dirent, filldir_t filldir)
> >+{
> >+ int error;
> >+
> >+ if (strcmp(current->comm, "nfsd") != 0)
>
> Is not there a better way to do this? Note that there is also a "nfsd4" process

This is in fact not allowed at at all. Please fix you readdir code not to
need special cases for nfsd.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-16 15:45    [W:0.080 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site