Messages in this thread Patch in this message | | | Date | Fri, 15 Sep 2006 12:33:40 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] mpparse.c:231: warning: comparison is always false |
| |
On Fri, 15 Sep 2006 11:23:49 -0400 Dave Jones <davej@redhat.com> wrote:
> On Fri, Sep 15, 2006 at 01:23:02AM -0700, Andrew Morton wrote: > > > > > Thanks. Andi has already queued a similar patch. > > > > > > > > Andi, you might as well scoot that upstream, otherwise we'll get lots of > > > > emails about it. > > > ... > > > > > +#if 0xFF >= MAX_MP_BUSSES > > > > > if (m->mpc_busid >= MAX_MP_BUSSES) { > > > I don't know how Andi has fixed it, > > Same thing. (He has `#if MAX_MP_BUSSES < 256'). > > How can this be the right the right thing to do ? > It should *never* be >=256. mach-summit/mach-generic need fixing > to be 255, not this ridiculous band-aid. Where did 260 come from anyway? >
commit f0bacaf5cec4e677a00b5ab06d95664d03a30f7a Author: akpm <akpm> Date: Mon Apr 12 20:06:32 2004 +0000
[PATCH] summmit: increase MAX_MP_BUSSES From: James Cleverdon <jamesclv@us.ibm.com> Bump up MAX_MP_BUSSES for summit/generic subarch to cope with big IBM x440 systems. BKrev: 407af6c8l8rvwRmEU-JHTS98MurIZA
diff --git a/include/asm-i386/mach-generic/mach_mpspec.h b/include/asm-i386/mach-generic/mach_mpspec.h index ef10cd2..fbb6a40 100644 --- a/include/asm-i386/mach-generic/mach_mpspec.h +++ b/include/asm-i386/mach-generic/mach_mpspec.h @@ -8,6 +8,8 @@ #define MAX_APICS 256 #define MAX_IRQ_SOURCES 256 -#define MAX_MP_BUSSES 32 +/* Summit or generic (i.e. installer) kernels need lots of bus entries. */ +/* Maximum 256 PCI busses, plus 1 ISA bus in each of 4 cabinets. */ +#define MAX_MP_BUSSES 260 #endif /* __ASM_MACH_MPSPEC_H */ diff --git a/include/asm-i386/mach-summit/mach_mpspec.h b/include/asm-i386/mach-summit/mach_mpspec.h index ef10cd2..bc8f717 100644 --- a/include/asm-i386/mach-summit/mach_mpspec.h +++ b/include/asm-i386/mach-summit/mach_mpspec.h @@ -8,6 +8,7 @@ #define MAX_APICS 256 #define MAX_IRQ_SOURCES 256 -#define MAX_MP_BUSSES 32 +/* Maximum 256 PCI busses, plus 1 ISA bus in each of 4 cabinets. */ +#define MAX_MP_BUSSES 260 #endif /* __ASM_MACH_MPSPEC_H */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |