lkml.org 
[lkml]   [2006]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] piix: Use refcounted interface when searching for a 450NX
    Hello.

    Alan Cox wrote:
    > Simple conversion
    >
    > Signed-off-by: Alan Cox <alan@redhat.com>
    >
    > diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc6-mm1/drivers/ide/pci/piix.c linux-2.6.18-rc6-mm1/drivers/ide/pci/piix.c
    > --- linux.vanilla-2.6.18-rc6-mm1/drivers/ide/pci/piix.c 2006-09-11 17:00:09.000000000 +0100
    > +++ linux-2.6.18-rc6-mm1/drivers/ide/pci/piix.c 2006-09-14 17:19:12.000000000 +0100
    > @@ -602,7 +602,7 @@
    > struct pci_dev *pdev = NULL;
    > u16 cfg;
    > u8 rev;
    > - while((pdev=pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
    > + while((pdev=pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
    > {
    > /* Look for 450NX PXB. Check for problem configurations
    > A PCI quirk checks bit 6 already */

    Shouldn't pci_put_dev() be called after the bridge device no longer needed?
    I assume it's not needed anymore after this function is finished...

    WBR, Sergei
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-15 16:15    [W:0.029 / U:2.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site