Messages in this thread | | | Date | Thu, 14 Sep 2006 07:36:47 +0200 | From | Jarek Poplawski <> | Subject | Re: [PATCH] mpparse.c:231: warning: comparison is always false |
| |
On Wed, Sep 13, 2006 at 12:42:51PM -0400, Dave Jones wrote: > On Wed, Sep 13, 2006 at 08:50:10AM +0200, Jarek Poplawski wrote: ... > > +#if 0xFF >= MAX_MP_BUSSES > > if (m->mpc_busid >= MAX_MP_BUSSES) { > > printk(KERN_WARNING "MP table busid value (%d) for bustype %s " > > " is too large, max. supported is %d\n", > > m->mpc_busid, str, MAX_MP_BUSSES - 1); > > return; > > } > > +#endif > > mpc_busid is a uchar. I don't see how this can ever be > 0xff, yet > mach-summit and mach-generic have MAX_MP_BUSSES set to 260. > > I don't see how this can possibly work. > > Dave >
0xFF >= 260 is false so the block is not compiled and the warning is gone (+ several bytes of useless code).
Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |