Messages in this thread Patch in this message | | | From | David Howells <> | Subject | [PATCH 6/7] Alter roundup_pow_of_two() so that it can make use of ilog2() on a constant [try #2] | Date | Wed, 13 Sep 2006 18:59:45 +0100 |
| |
From: David Howells <dhowells@redhat.com>
Alter roundup_pow_of_two() so that it can make use of ilog2() on a constant to produce a constant value, retaining the ability for an arch to override it in the non-const case.
This permits the function to be used to initialise variables.
Signed-Off-By: David Howells <dhowells@redhat.com> ---
include/linux/kernel.h | 6 ------ include/linux/log2.h | 26 ++++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 6 deletions(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h index e8c6c66..e5947fb 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -155,12 +155,6 @@ #endif unsigned long int_sqrt(unsigned long); -static inline unsigned long -__attribute_const__ roundup_pow_of_two(unsigned long x) -{ - return 1UL << fls_long(x - 1); -} - extern int printk_ratelimit(void); extern int __printk_ratelimit(int ratelimit_jiffies, int ratelimit_burst); diff --git a/include/linux/log2.h b/include/linux/log2.h index 88b7b0e..c7574a6 100644 --- a/include/linux/log2.h +++ b/include/linux/log2.h @@ -73,6 +73,15 @@ #endif } #endif +/* + * round up to nearest power of two + */ +static inline __attribute__((const)) +unsigned long __roundup_pow_of_two(unsigned long n) +{ + return 1UL << fls_long(n - 1); +} + /** * ilog2_u32 - log of base 2 of 32-bit unsigned value * @n - parameter @@ -230,4 +239,21 @@ ( \ __get_order(n, PAGE_SHIFT) \ ) +/** + * roundup_pow_of_two - round the given value up to nearest power of two + * @n - parameter + * + * round the given balue up to the nearest power of two + * - the result is undefined when n == 0 + * - this can be used to initialise global variables from constant data + */ +#define roundup_pow_of_two(n) \ +( \ + __builtin_constant_p(n) ? ( \ + (n == 1) ? 0 : \ + (1UL << (ilog2((n) - 1) + 1)) \ + ) : \ + __roundup_pow_of_two(n) \ + ) + #endif /* _LINUX_LOG2_H */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |