Messages in this thread | | | From | David Howells <> | Subject | Re: kernel BUGs when removing largish files with the SLOB allocator | Date | Tue, 12 Sep 2006 22:59:45 +0100 |
| |
Matt Mackall <mpm@selenic.com> wrote:
> The only tricky part is the timer points back to _this very function_.
OIC. Brrr. That _definitely_ needs commenting - as has been demonstrated. SLOB is using the theoretically one-shot initiator to do garbage collection.
The:
if (size == PAGE_SIZE) /* trying to shrink arena? */ return 0;
In slob_alloc() definitely looks very dodgy, now that I see it. What happens if some normal user asks to allocate exactly a page? Oh... I suppose it never gets into slob_alloc() to allocate the main piece of storage.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |