lkml.org 
[lkml]   [2006]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH] usbserial: Reference leak
    From
    A sufficiently-large number of USB serial devices causes a reference leak
    when /proc/tty/drivers/usbserial is read.

    Signed-Off-By: Matthias Urlichs <smurf@smurf.noris.de>
    ---
    This should be in 2.6.18, for obvious reasons.
    It also applies to older 2.6 kernels.)
    ---
    diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
    index 3e96350..fae1410 100644
    --- a/drivers/usb/serial/usb-serial.c
    +++ b/drivers/usb/serial/usb-serial.c
    @@ -471,8 +471,10 @@ static int serial_read_proc (char *page,
    length += sprintf (page+length, " path:%s", tmp);

    length += sprintf (page+length, "\n");
    - if ((length + begin) > (off + count))
    + if ((length + begin) > (off + count)) {
    + usb_serial_put(serial);
    goto done;
    + }
    if ((length + begin) < off) {
    begin += length;
    length = 0;
    --
    Matthias Urlichs | {M:U} IT Design @ m-u-it.de | smurf@smurf.noris.de
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-09-11 12:39    [W:4.983 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site