Messages in this thread | | | Date | Mon, 11 Sep 2006 12:17:26 +0200 | From | Cedric Le Goater <> | Subject | Re: [patch -mm] update mq_notify to use a struct pid |
| |
Eric W. Biederman wrote: > Cedric Le Goater <clg@fr.ibm.com> writes: > >> message queues can signal a process waiting for a message. >> >> this patch replaces the pid_t value with a struct pid to avoid pid wrap >> around problems. >> >> Signed-off-by: Cedric Le Goater <clg@fr.ibm.com> >> Cc: Eric Biederman <ebiederm@xmission.com> >> Cc: Andrew Morton <akpm@osdl.org> >> Cc: containers@lists.osdl.org > > Signed-off-by: Eric Biederman <ebiederm@xmission.com> > > I was just about to send out this patch in a couple more hours.
Well, you did the same with the usb/devio.c and friends :)
> So expect the fact we wrote the same code is a good sign :)
How does oleg feel about it ? I've seen some long thread on possible race conditions with put_pid() and solutions with rcu. I didn't quite get all of it ... it will need another run for me.
On the "pid_t to struct pid*" topic:
* I started smbfs and realized it was useless.
* in the following, the init process is being killed directly using 1. I'm not sure how useful it would be to use a struct pid. To begin with, may be they could use a :
kill_init(int signum, int priv)
./arch/mips/sgi-ip32/ip32-reset.c ./arch/powerpc/platforms/iseries/mf.c ./drivers/parisc/power.c ./drivers/char/snsc_event.c ./kernel/sys.c ./kernel/sysctl.c ./drivers/char/nwbutton.c ./drivers/s390/s390mach.c
* some more drivers, * some more kthread to convert
C. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |