Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] raw: return negative from raw_init() | Date | Mon, 11 Sep 2006 23:34:19 -0400 |
| |
On Monday 11 September 2006 21:19, Alexey Dobriyan wrote: > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > drivers/char/raw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/char/raw.c > +++ b/drivers/char/raw.c > @@ -312,7 +312,7 @@ static int __init raw_init(void) > > error: > printk(KERN_ERR "error register raw device\n"); > - return 1; > + return -1; > } >
How about reworking it a bit to pass true error code from the failed call? Additionally class_device_create call is not checked for errors there.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |