lkml.org 
[lkml]   [2006]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/19] dmaengine: add dma_sync_wait
Dan Williams wrote:
> From: Dan Williams <dan.j.williams@intel.com>
>
> dma_sync_wait is a common routine to live wait for a dma operation to
> complete.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>
> include/linux/dmaengine.h | 12 ++++++++++++
> 1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 9fd6cbd..0a70c9e 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -750,6 +750,18 @@ static inline void dma_async_unmap_singl
> chan->device->unmap_single(chan, handle, size, direction);
> }
>
> +static inline enum dma_status dma_sync_wait(struct dma_chan *chan,
> + dma_cookie_t cookie)
> +{
> + enum dma_status status;
> + dma_async_issue_pending(chan);
> + do {
> + status = dma_async_operation_complete(chan, cookie, NULL, NULL);
> + } while (status == DMA_IN_PROGRESS);
> +
> + return status;

Where are the timeouts, etc.? Looks like an infinite loop to me, in the
worst case.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-12 19:19    [W:0.280 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site