lkml.org 
[lkml]   [2006]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: What's in libata-dev.git


On Mon, 11 Sep 2006, Jeff Garzik wrote:

> Sergei Shtylyov wrote:
> > It's not likely I'll be able to try it. But I'm absolutely sure that
> > drive aborted the read commands with the sector count of 0 (i.e. 256
> > actually). The exact model was IBM DHEA-34331.
> > 255 sectors actually seems more safe bet.
>
> This sort of thing should be handled by quirks, depending on the controller
> and drive.

Please don't play games with peoples data-safety.

It ios absolutely INCORRECT to think that "things should work as
documented, let's fix it up with quirks".

It's a hell of a lot better to instead say "people f*ck up, this is a
known point of trouble, and let's just not push the envelope that hard".

Making max-sectors be 255 instead of 256 just _avoids_ the problem that
the ATA protocol uses a single-byte control register for the sector
number, and that "0" is supposed to mean "256", but people have been
_known_ to get it wrong several times.

It's not like it's even strange and inexplicable that some drive
controller would think that "zero means zero". Quite the reverse. It's a
strange special case, and it's not surprising at all that people would
have gotten it wrong several times independently.

It's not even like you'd get magically higher performance by using 256
sectors, so there's simply no win from living dangerously. Only losses.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-11-18 23:46    [W:0.094 / U:16.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site