lkml.org 
[lkml]   [2006]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 004 of 19] knfsd: lockd: introduce nsm_handle
    On Fri, 1 Sep 2006 14:38:25 +1000
    NeilBrown <neilb@suse.de> wrote:

    > +nsm_release(struct nsm_handle *nsm)
    > +{
    > + if (!nsm)
    > + return;
    > + if (atomic_read(&nsm->sm_count) == 1) {
    > + down(&nsm_sema);
    > + if (atomic_dec_and_test(&nsm->sm_count)) {
    > + list_del(&nsm->sm_link);
    > + kfree(nsm);
    > + }
    > + up(&nsm_sema);
    > + }
    > +}

    That's weird-looking. Are you sure? afaict, if ->sm_count ever gets a
    value of 2 or more, it's unfreeable.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-09-01 08:23    [W:0.020 / U:2.428 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site