lkml.org 
[lkml]   [2006]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] prepare for write access checks: collapse if()
On Wed, Aug 09, 2006 at 09:57:30AM -0700, Dave Hansen wrote:
>
> We're shortly going to be adding a bunch more permission
> checks in these functions. That requires adding either a
> bunch of new if() conditions, or some gotos. This patch
> collapses existing if()s and uses gotos instead to
> prepare for the upcoming changes.
>
> Signed-off-by: Dave Hansen <haveblue@us.ibm.com>


Acked-by: Christoph Hellwig <hch@lst.de>

> + res = vfs_permission(&nd, mode);
> + /* SuS v2 requires we report a read only fs too */
> + if(res || !(mode & S_IWOTH) ||

except that there's a space missing after the if here :)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-09 19:11    [from the cache]
©2003-2011 Jasper Spaans