lkml.org 
[lkml]   [2006]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC: -mm patch] bcm43xx_main.c: remove 3 functions
    Date
    On Monday 07 August 2006 23:04, Adrian Bunk wrote:
    > This patch removes three no longer used functions (that are even
    > generating gcc warnings).
    >
    > This patch doesn't look right, but it is the result of
    > 58e5528ee464d38040b9489e10033c9387a10d56 in git-netdev...

    Hm, can't find that commit in a tree.
    I looked at linus', netdev-2.6.

    But one thing is for sure. This patch is _wrong_. ;)

    > Signed-off-by: Adrian Bunk <bunk@stusta.de>

    NACK.

    > drivers/net/wireless/bcm43xx/bcm43xx_main.c | 33 --------------------
    > 1 file changed, 33 deletions(-)
    >
    > --- linux-2.6.18-rc3-mm2-full/drivers/net/wireless/bcm43xx/bcm43xx_main.c.old 2006-08-07 18:21:31.000000000 +0200
    > +++ linux-2.6.18-rc3-mm2-full/drivers/net/wireless/bcm43xx/bcm43xx_main.c 2006-08-07 18:23:36.000000000 +0200
    > @@ -3194,39 +3194,6 @@
    > bcm43xx_clear_keys(bcm);
    > }
    >
    > -static int bcm43xx_rng_read(struct hwrng *rng, u32 *data)
    > -{
    > - struct bcm43xx_private *bcm = (struct bcm43xx_private *)rng->priv;
    > - unsigned long flags;
    > -
    > - spin_lock_irqsave(&(bcm)->irq_lock, flags);
    > - *data = bcm43xx_read16(bcm, BCM43xx_MMIO_RNG);
    > - spin_unlock_irqrestore(&(bcm)->irq_lock, flags);
    > -
    > - return (sizeof(u16));
    > -}
    > -
    > -static void bcm43xx_rng_exit(struct bcm43xx_private *bcm)
    > -{
    > - hwrng_unregister(&bcm->rng);
    > -}
    > -
    > -static int bcm43xx_rng_init(struct bcm43xx_private *bcm)
    > -{
    > - int err;
    > -
    > - snprintf(bcm->rng_name, ARRAY_SIZE(bcm->rng_name),
    > - "%s_%s", KBUILD_MODNAME, bcm->net_dev->name);
    > - bcm->rng.name = bcm->rng_name;
    > - bcm->rng.data_read = bcm43xx_rng_read;
    > - bcm->rng.priv = (unsigned long)bcm;
    > - err = hwrng_register(&bcm->rng);
    > - if (err)
    > - printk(KERN_ERR PFX "RNG init failed (%d)\n", err);
    > -
    > - return err;
    > -}
    > -
    > static int bcm43xx_shutdown_all_wireless_cores(struct bcm43xx_private *bcm)
    > {

    --
    Greetings Michael.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-08 20:37    [W:0.022 / U:62.824 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site