Messages in this thread Patch in this message | | | Subject | PATCH: Voyager, tty locking | From | Alan Cox <> | Date | Tue, 08 Aug 2006 19:07:49 +0100 |
| |
Voyager fiddles with current->signal.tty without locking. It turns out that the code in question has already cleared current->signal.tty correctly because daemonize() does the right thing already.
The signal handling also appears to be incorrect as it does an unprotected sigfillset that also appears unneccessary. As I don't have a bowtie and am therefore not a qualified voyager maintainer I leave that to James.
Signed-off-by: Alan Cox <alan@redhat.com>
--- linux.vanilla-2.6.18-rc3-mm2/arch/i386/mach-voyager/voyager_thread.c 2006-08-07 16:15:02.000000000 +0100 +++ linux-2.6.18-rc3-mm2/arch/i386/mach-voyager/voyager_thread.c 2006-08-08 18:19:11.496378872 +0100 @@ -130,7 +130,6 @@ init_timer(&wakeup_timer); sigfillset(¤t->blocked); - current->signal->tty = NULL; printk(KERN_NOTICE "Voyager starting monitor thread\n"); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |