Messages in this thread | | | Date | Tue, 8 Aug 2006 16:43:37 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes |
| |
On Tue, Aug 08, 2006 at 04:35:23PM +0300, Shem Multinymous wrote: > Hi Muli, > > On 8/8/06, Muli Ben-Yehuda <muli@il.ibm.com> wrote: > >> > > ret = thinkpad_ec_lock(); > >> > > if (ret) > >> > > return ret; > > >Ugh, I missed that - it's called _lock(), but it's actually > >down_interruptible(). > > Why is that confusing?
lock() sounds like spin_lock() to me, and spin_lock() can't fail. Idiomatic code is easier for my brain to parse.
> >Why not just get rid of the wrapper and call > >down_interruptible() directly? That makes it obvious what's going on. > > We may end up needing to lock away other subsystems (ACPI?) that > touch the same ports. Apparently not an issue right now, but could > change with new firmware. (http://lkml.org/lkml/2006/8/7/147)
When (if) it becomes necessary to lock away other subsystems, the wrapper can be easily reintroduced.
Cheers, Muli
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |