lkml.org 
[lkml]   [2006]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] hdaps: Limit hardware query rate
Hi!

> The current hdaps driver queries the hardware on (almost) any sysfs read.
> Since fresh readouts are genereated by the hardware at a constant rate,
> this means apps are eating each other's events. Also, polling multiple
> attributes will genereate excessive hardware queries and excessive CPU
> load due to the duration of the hardware query transaction.
>
> With this patch, the driver will normally update its cached readouts
> only in its timer function (which exists anyway, for the input device).
> If that read failed, it will be retried upon the actual sysfs access.
> In all cases, query rate is bounded and apps will get reasonably
> fresh and usually cached readouts.
>
> The polling rate is increased to 50Hz, as needed by the hdaps daemon.
> A later patch makes this configurable.
>
> Signed-off-by: Shem Multinymous <multinymous@gmail.com>

I'd insert fewer blank lines, otherwise patch looks ok to me.

Signed-off-by: Pavel Machek <pavel@suse.cz>

--
Thanks for all the (sleeping) penguins.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-08 14:53    [W:0.219 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site