Messages in this thread | | | Date | Fri, 04 Aug 2006 21:26:23 -0700 | From | Zachary Amsden <> | Subject | Re: [patch 3/8] Allow a kernel to not be in ring 0. |
| |
Chuck Ebbert wrote: > In-Reply-To: <20060803002518.190834642@xensource.com> > > On Wed, 02 Aug 2006 17:25:13 -0700, Jeremy Fitzhardinge wrote: > > >> We allow for the fact that the guest kernel may not run in ring 0. >> This requires some abstraction in a few places when setting %cs or >> checking privilege level (user vs kernel). >> > > I made some changes: > > a. Added some comments about the SEGMENT_IS_*_CODE() macros. > b. Added a USER_RPL macro. (You were comparing a value to a mask > in some places and to the magic number 3 in other places.) > c. Changed the entry.S tests for LDT stack segment to use the macros. >
These changes look great. Ack-ed. I had some similar ones before that never made it from my tree, as I got carried away and tried to unify the user descriptor conversion functions... someday I'll get to it again.
Zach - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |