lkml.org 
[lkml]   [2006]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] eicon: fix define conflict with ptrace
On Thu, 3 Aug 2006, Alan Cox wrote:
> Ar Gwe, 2006-08-04 am 00:34 +0400, ysgrifennodd Alexey Dobriyan:
> > * MODE_MASK is unused in eicon driver.
> > * Conflicts with a ptrace stuff on arm.
> >
> > drivers/isdn/hardware/eicon/divasync.h:259:1: warning: "MODE_MASK" redefined
> > include2/asm/ptrace.h:48:1: warning: this is the location of the previous definition
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> NAK. You need to fix all the code expecting to use the MODE_MASK with a
> value of 0x00000080

The definitions in drivers/isdn/hardware/eicon/divasync.h are for
Eicon driver only. Since MODE_MASK is not really used in the Eicon/Divas
driver, the removal from this file is okay.

Armin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-04 16:39    [from the cache]
©2003-2011 Jasper Spaans