lkml.org 
[lkml]   [2006]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2.4.32] Fix AVM C4 ISDN card init problems with newer CPUs
From
Date
Ar Iau, 2006-08-03 am 19:31 +0200, ysgrifennodd Karsten Keil:
> Yes, that should be go in.
>
> AVM C4 ISDN NIC: Add three memory barriers, taken from 2.6.7,
> (they are there in 2.6.17.7 too), to fix module initialization
> problems appearing with at least some newer Celerons and
> Pentium III.
>
> Acked-by: Karsten Keil <kkeil@suse.de>
> Signed-off-by: Jukka Partanen <jspartanen@gmail.com>

NAK: Alan Cox <alan@redhat.com>

Two reasons

#1 You should use cpu_relax in such loops
#2 The readl (which c4inmeml is a pointless #define of) is defined to be
a volatile reference itself

That means that the real bug would appear to be different and either you
have a gcc bug which is possible or you have something stranger going
on, such as the continued polling busying the microcontroller the other
end, in which case you need a delay not the lucky chance that mb() is
slowish on some x86 systems.

So you either want

cpu_relax + other fixes
or udelay(something)


Alan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-04 11:45    [from the cache]
©2003-2011 Jasper Spaans