Messages in this thread | | | Subject | Re: [FOR 2.6.18 FIX][PATCH] drm: radeon flush TCL VAP for vertex program enable/disable | From | Arjan van de Ven <> | Date | Thu, 31 Aug 2006 08:27:13 +0200 |
| |
On Wed, 2006-08-30 at 15:53 -0700, Linus Torvalds wrote: > > On Wed, 30 Aug 2006, Andrew Morton wrote: > > > > That's a somewhat weird-looking patch. It adds code which is quite > > dissimilar from all the other cases in that switch statement. > > It looks ok to me, although you have to look into the caller to see why it > does what it does. > > It would be "prettier" if it changed the size and data of the incoming > packet instead, but the code as is isn't actually set up to be able to do > that (the size setup and verification stuff is done before the fixup). > > That said, I'd have expected that the VAP state flush is really something > that the _client_ should do when it generates the commands, not the kernel > after the fact.
but the client is unprivileged userspace! The kernel needs to ensure correctness and probably even enforce it.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |